Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameters_visualization): visualize test iteration parameters #1346

Conversation

ahmeddesokyebrahim
Copy link

@ahmeddesokyebrahim ahmeddesokyebrahim commented Aug 20, 2024

Description

fixes #1272

Abstract

This PR is to add the ability for scenario simulator to report the parameters used in each iteration as described in this feature request.
The PR is adding this parameters reporting using both command line print and rviz plugin visualization that can enabled when needed

Background

Please refer to the feature request.

Details

Using this PR, the parameters are printed to command line and visualized in RVIZ as follows :

  • RVIZ :
    image
  • Terminal :
    image

References

N.A

Destructive Changes

N.A

Known Limitations

@ahmeddesokyebrahim ahmeddesokyebrahim changed the base branch from master to RJD-736/autoware_msgs_support August 20, 2024 10:06
@hakuturu583
Copy link
Collaborator

hakuturu583 commented Sep 2, 2024

@ahmeddesokyebrahim Why the base branch of this pull request is not master branch?
I reviewed your diff but it is not depends on autoware_msgs branch.

@hakuturu583 hakuturu583 changed the base branch from RJD-736/autoware_msgs_support to master September 2, 2024 06:31
@hakuturu583 hakuturu583 changed the base branch from master to RJD-736/autoware_msgs_support September 2, 2024 06:32
@ahmeddesokyebrahim
Copy link
Author

Why the base branch of this pull request is not master branch? I reviewed your diff but it is not depends on autoware_msgs branch.

Thanks @hakuturu583 -san for your reply.
As was under impression that this is the branch used due to this change here.

So, the needed fix now is to have the target or base branch for the PR to be master. Is it correct ?

@ahmeddesokyebrahim
Copy link
Author

Hi @hakuturu583 -san,

Is this PR set up as needed ?

If yes, I can close this one and consider the new PR.

@hakuturu583
Copy link
Collaborator

So, the needed fix now is to have the target or base branch for the PR to be master. Is it correct ?

Yes. I think this base branch of this pull request should be master.
I checked diff but it seems this pull request does not depends on autoware_msgs

@hakuturu583
Copy link
Collaborator

Hi @hakuturu583 -san,
Is this #1360 set up as needed ?
If yes, I can close this one and consider the new PR.

I think this is very helpful feature.
Could you re-open pull request based on master branch?

@ahmeddesokyebrahim
Copy link
Author

I think this is very helpful feature.
Could you re-open pull request based on master branch?

Thanks for your comment @hakuturu583 -san
Can you please check this PR #1360 ?

@hakuturu583
Copy link
Collaborator

@ahmeddesokyebrahim Thanks!
I will check!

@hakuturu583
Copy link
Collaborator

@ahmeddesokyebrahim Thak you for re-opening new pull request.
Can I close this pull request?

@ahmeddesokyebrahim
Copy link
Author

@ahmeddesokyebrahim Thak you for re-opening new pull request. Can I close this pull request?

Thanks for your comment @hakuturu583 -san.

I close this PR with this comment and we consider the other PR based on master branch.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing scenario_simulator_v2 to print or visualize parameters/modifiers used for test iterations
2 participants